Include soft keywords for is_keyword
check
#11445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
TokenKind::is_keyword
check to include soft keywords. To account for this change, it adds a newis_non_soft_keyword
method.The usage in logical line rules were updated to use the
is_non_soft_keyword
method but it'll be updated to useis_keyword
in a follow-up PR (#11446).While, the parser usages were kept as is. And because of that, the snapshots for two test cases were updated in a better direction.
Test Plan
cargo insta test