Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-self] Ignore sunder accesses in flake8-self rule #11546

Merged
merged 1 commit into from
May 26, 2024
Merged

Conversation

charliermarsh
Copy link
Member

Summary

We already ignore dunders, so ignoring sunders (as in https://docs.python.org/3/library/enum.html#supported-sunder-names) makes sense to me.

@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label May 26, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 1 projects; 49 projects unchanged)

apache/airflow (+0 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --no-preview --select ALL

- tests/providers/elasticsearch/log/test_es_response.py:201:16: SLF001 Private member accessed: `_d_`
- tests/providers/elasticsearch/log/test_es_response.py:53:16: SLF001 Private member accessed: `_l_`
- tests/providers/elasticsearch/log/test_es_response.py:57:16: SLF001 Private member accessed: `_l_`
- tests/providers/elasticsearch/log/test_es_response.py:87:16: SLF001 Private member accessed: `_d_`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
SLF001 4 0 4 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -4 violations, +0 -0 fixes in 1 projects; 49 projects unchanged)

apache/airflow (+0 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

- tests/providers/elasticsearch/log/test_es_response.py:201:16: SLF001 Private member accessed: `_d_`
- tests/providers/elasticsearch/log/test_es_response.py:53:16: SLF001 Private member accessed: `_l_`
- tests/providers/elasticsearch/log/test_es_response.py:57:16: SLF001 Private member accessed: `_l_`
- tests/providers/elasticsearch/log/test_es_response.py:87:16: SLF001 Private member accessed: `_d_`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
SLF001 4 0 4 0 0

@charliermarsh charliermarsh merged commit 650c578 into main May 26, 2024
19 checks passed
@charliermarsh charliermarsh deleted the charlie/s branch May 26, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant