Use default settings if initialization options is empty or not provided #11566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the bug to avoid flattening the global-only settings for the new server.
This was added in #11497, possibly to correctly de-serialize an empty value (
{}
). But, this lead to a bug where the configuration under thesettings
key was not being read for global-only variant.By using #[serde(default)], we ensure that the settings field in the
GlobalOnly
variant is optional and that an empty JSON object{}
is correctly deserialized intoGlobalOnly
with a defaultClientSettings
instance.fixes: #11507
Test Plan
Update the snapshot and existing test case. Also, verify the following settings in Neovim:
settings