Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ruff_notebook a workspace dependency in ruff_server #11572

Merged
merged 1 commit into from
May 28, 2024

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented May 27, 2024

Summary

The ruff_notebook dependency was added in https://github.dev/astral-sh/ruff/pull/11206

I suspect it's a merge conflict. So lets update the dependency to use the format that Charlie prefers ;)

Test Plan

cargo build

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup :)

@MichaReiser MichaReiser added the internal An internal refactor or improvement label May 27, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser merged commit 3989cb8 into main May 28, 2024
19 checks passed
@MichaReiser MichaReiser deleted the server-notebook-workspace-dependency branch May 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants