Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F401 use BTreeMap instead of FxHashMap #11621

Merged
merged 2 commits into from
May 30, 2024
Merged

F401 use BTreeMap instead of FxHashMap #11621

merged 2 commits into from
May 30, 2024

Conversation

plredmond
Copy link
Contributor

@plredmond plredmond commented May 30, 2024 •
edited
Loading

  • Potentially resolves Test failure for 0.4.6 on s390x #11619 (nondeterministic hashmap order across different architectures) in F401 by replacing a hashmap with nondeterministic traversal order with an ordered mapping.

I'm not sure how to test this with our CI/CD. I don't have an s390x machine at home. Should I try it in Qemu?

@plredmond plredmond self-assigned this May 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 30, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@plredmond plredmond changed the title F401 use indexmap instead of hashmap F401 use BTreeMap instead of FxHashmap May 30, 2024
@plredmond plredmond changed the title F401 use BTreeMap instead of FxHashmap F401 use BTreeMap instead of FxHashMap May 30, 2024
@charliermarsh
Copy link
Member

I would just ship it and ask the original filer if it's resolved.

@plredmond
Copy link
Contributor Author

SGTM. I was having "uncompression error" trying to get an alpine s390x iso to start in qemu. Merging now.

@plredmond plredmond merged commit dcabd04 into main May 30, 2024
19 checks passed
@plredmond plredmond deleted the ruff.f401.nondet branch May 30, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

Assignees

@plredmond plredmond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure for 0.4.6 on s390x
2 participants
@plredmond @charliermarsh