Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] infer int literal types #11623

Merged
merged 2 commits into from
May 31, 2024
Merged

[red-knot] infer int literal types #11623

merged 2 commits into from
May 31, 2024

Conversation

carljm
Copy link
Contributor

@carljm carljm commented May 30, 2024

Summary

Give red-knot the ability to infer int literal types. This is quick and easy, mostly because these types are a convenient way to observe control-flow handling with simple assignments.

Test Plan

Added test.

Copy link
Contributor

github-actions bot commented May 30, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@carljm carljm added the internal An internal refactor or improvement label May 31, 2024
crates/red_knot/src/types/infer.rs Outdated Show resolved Hide resolved
crates/red_knot/src/types/infer.rs Outdated Show resolved Hide resolved
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo comments

@carljm carljm merged commit 16a926d into astral-sh:main May 31, 2024
19 checks passed
@carljm carljm deleted the intlit branch May 31, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants