F401 sort bindings before adding to __all__ #11648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up sorting the slice rather than the result of the iter/map because that saves a copy. I made the function argument |
|
| @@ -330,7 +330,7 @@ pub(crate) fn unused_import(checker: &Checker, scope: &Scope, diagnostics: &mut | |||
| fix_by_reexporting( | |||
| checker, | |||
| import_statement, | |||
| &to_reexport.iter().map(|(b, _)| b).collect::<Vec<_>>(), | |||
| &mut to_reexport.iter().map(|(b, _)| b).collect::<Vec<_>>(), | |||
There was a problem hiding this comment.
Maybe we should just pass in the Vec here, so the ownership is clearer? Then it can be mut imports: Vec<&ImportBinding> and callers don't need to worry about the mutation.
There was a problem hiding this comment.
Tweaking this quickly so I can include in the release.
There was a problem hiding this comment.
Ok! Thanks for explaining
charliermarsh
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the binding IDs before passing them to the add-to-
__all__function to address #11619.