ruff server
: Formatting a document with syntax problems no longer spams a visible error popup
#11745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes astral-sh/ruff-vscode#482.
I've made adjustments to
format
andformat_range
that handle parsing errors before they become server errors. We'll still log this as a problem, but there will no longer be a visible popup.Test Plan
Instead of seeing a visible error when formatting a document with syntax issues, you should see this warning in the LSP logs:
Similarly, if you try to format a range with syntax issues, you should see this warning in the LSP logs instead of a visible error popup: