Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ruff_db a required crate for ruff_python_semantic #11874

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

dhruvmanila
Copy link
Member

Summary

This PR makes the ruff_db a required crate for ruff_python_semantic.

Refer https://github.com/astral-sh/ruff/actions/runs/9516626143/job/26233307158?pr=11872

Test Plan

  1. maturin sdist --out dist
  2. tar -xf dist/ruff-0.4.8.tar.gz --directory=dist/ruff-0.4.8
  3. pip install dist/ruff-0.4.8.tar.gz works

@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Jun 14, 2024
@dhruvmanila dhruvmanila requested a review from MichaReiser June 14, 2024 13:34
Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #11874 will degrade performances by 11.77%

Comparing dhruv/ruff-db (995d1d3) with main (89bb07c)

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dhruv/ruff-db Change
linter/all-with-preview-rules[numpy/globals.py] 803.8 µs 911 µs -11.77%

@MichaReiser MichaReiser merged commit d681a45 into main Jun 14, 2024
19 of 20 checks passed
@MichaReiser MichaReiser deleted the dhruv/ruff-db branch June 14, 2024 13:43
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants