Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove check, --explain, --clean, --generate-shell-completion aliases #12011

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Remove check, --explain, --clean, --generate-shell-completion aliases #12011

merged 2 commits into from
Jun 25, 2024

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Jun 24, 2024 •
edited
Loading

Summary

This PR changes ruff <path>, ruff --explain, ruff --clean and ruff --generate-shell-completion to error but continues to print an error message. The commands were deprecated in #10169 (v0.3.0)

Part of #10171

Test Plan

I verified that:

  • The JetBrains extension uses ruff check
  • The LSP uses ruff check
  • python-lsp-ruff I think it uses ruff check

@MichaReiser MichaReiser changed the base branch from main to ruff-0.5 June 24, 2024 09:30
@MichaReiser MichaReiser added breaking Breaking API change cli Related to the command-line interface labels Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser marked this pull request as ready for review June 24, 2024 10:07
@dhruvmanila dhruvmanila mentioned this pull request Jun 24, 2024
Merged
@dhruvmanila
Copy link
Member

I'm looking at the Neovim ecosystem, already completed in conform.nvim: stevearc/conform.nvim#348

zanieb
zanieb reviewed Jun 24, 2024
View reviewed changes
docs/configuration.md Outdated Show resolved Hide resolved
@MichaReiser
Copy link
Member Author

I changed the implementation to error instead of removing the aliases entirely.

@MichaReiser MichaReiser mentioned this pull request Jun 25, 2024
Closed
@MichaReiser MichaReiser changed the title Remove check, --explain, --clean, --generate-shell-completion aliases` Remove check, --explain, --clean, --generate-shell-completion aliases Jun 25, 2024
@MichaReiser MichaReiser merged commit 3ad1c6c into ruff-0.5 Jun 25, 2024
20 checks passed
@MichaReiser MichaReiser deleted the remove-CLI-aliases branch June 25, 2024 07:23
@MichaReiser MichaReiser mentioned this pull request Jun 26, 2024
Merged
MichaReiser added a commit that referenced this pull request Jun 27, 2024
@MichaReiser
Remove check, --explain, --clean, --generate-shell-completion…
b62b73b 
… aliases (#12011)
MichaReiser added a commit that referenced this pull request Jun 27, 2024
@MichaReiser
Remove check, --explain, --clean, --generate-shell-completion…
36a9efd 
… aliases (#12011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb left review comments

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
breaking Breaking API change cli Related to the command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaReiser @dhruvmanila @charliermarsh @zanieb