Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match import name ignores against both name and alias #12033

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Right now, it's inconsistent... We sometimes match against the name, and sometimes against the alias (asname). I could see a case for always matching against the name, but matching against both seems fine too, since the rule is really about the combination of the two?

Closes #12031.

@charliermarsh charliermarsh added the bug Something isn't working label Jun 25, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 83fe447 into main Jun 25, 2024
20 checks passed
@charliermarsh charliermarsh deleted the charlie/ignore branch June 25, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: allowlist setting for N812/N817
1 participant