Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more NPY201 tests #12087

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Add more NPY201 tests #12087

merged 3 commits into from
Jun 28, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Adds more tests for NPY201 as mentioned here.

I also split the tests into multiple files and reduced the max iteration limit back to 10.

Test Plan

cargo test

@MichaReiser
Copy link
Member Author

MichaReiser commented Jun 28, 2024

@mtsokol could you take a look at the test output. Does the output look correct to you?

The output of the newly added tests are all in

0420ed1

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Jun 28, 2024
Copy link
Contributor

@mtsokol mtsokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! They're all correct - thanks!

@MichaReiser MichaReiser merged commit 117ab78 into main Jun 28, 2024
20 checks passed
@MichaReiser MichaReiser deleted the npy201-tests branch June 28, 2024 07:58
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

demisto/content (error)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'ignore' -> 'lint.ignore'
  - 'select' -> 'lint.select'
  - 'unfixable' -> 'lint.unfixable'
  - 'per-file-ignores' -> 'lint.per-file-ignores'
warning: `PGH001` has been remapped to `S307`.
warning: `PGH002` has been remapped to `G010`.
warning: `PLR1701` has been remapped to `SIM101`.
ruff failed
  Cause: Selection of deprecated rule `E999` is not allowed when preview is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants