Remove allocation in parse_identifier
#12103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I think this PR removes an allocation from
parse_identifier
.parse_identifier
converts theBox<str>
from theTokenValue::Name
to aString
by calling.to_string
.to_string
is a small wrapper aroundformat!("{name}")
which allocates a new string without reusing theBox<str>
allocation, unless the compiler can see through the operation.This PR uses
Box<str>::into_string
which, to my knowledge, reuses the underlying allocation.Test Plan
cargo test