Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rules): skip dummy variables for PLR1704 #12190

Merged
merged 2 commits into from
Jul 4, 2024
Merged

fix(rules): skip dummy variables for PLR1704 #12190

merged 2 commits into from
Jul 4, 2024

Conversation

mkniewallner
Copy link
Contributor

Summary

Resolves #12157.

Test Plan

Snapshot tests.

@mkniewallner mkniewallner marked this pull request as ready for review July 4, 2024 18:47
@charliermarsh charliermarsh self-assigned this Jul 4, 2024
@charliermarsh charliermarsh added the bug Something isn't working label Jul 4, 2024
charliermarsh
charliermarsh approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charliermarsh charliermarsh enabled auto-merge (squash) July 4, 2024 20:06
@charliermarsh charliermarsh merged commit 2f3264e into astral-sh:main Jul 4, 2024
16 checks passed
@mkniewallner mkniewallner deleted the fix/issue-12157 branch July 5, 2024 13:06
@BrewTestBot BrewTestBot mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PLR1704 issued for _ variable
2 participants
@mkniewallner @charliermarsh