[numpy] Update NPY201: add np.NAN to exception
#12292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmatthias
commented
Jul 11, 2024
| @@ -68,3 +68,5 @@ def func(): | |||
| np.longfloat(12+34j) | |||
|
|
|||
| np.lookfor | |||
|
|
|||
| np.NAN | |||
There was a problem hiding this comment.
this could also be moved next to np.NaN - which i'd find more appealing as it'd really belong there - but i found the diff on the .snap file to be rather large - as it changes all subsequent line numbers...
let me know if you'd prefer that
That makes sense. I think that's best tackled as a separate pr |
MichaReiser
changed the title
np.NAN to exception
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
np.NAN was also deprecated / removed, as reported in #12195.
Personally, i'd also wan't to have warnings for
from numpy import nan, NaN, NAN(NAN and NaN shouldn't import as they've been removed) - but that's really out of my league - as there's no similar case at the moment (at least not in the NPY201 section).Obviously, this would "also" apply to essentially all other cases of deprecations.
Test Plan
Added testcase, manual test