Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit code frames for fixes with empty ranges #12304

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Omit code frames for fixes with empty ranges #12304

merged 4 commits into from
Jul 12, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #12291.

Test Plan

❯ cargo run check ../uv/foo --select INP
/Users/crmarsh/workspace/uv/foo/bar/baz.py:1:1: INP001 File `/Users/crmarsh/workspace/uv/foo/bar/baz.py` is part of an implicit namespace package. Add an `__init__.py`.
Found 1 error.

@charliermarsh charliermarsh added the cli Related to the command-line interface label Jul 12, 2024
dhruvmanila
dhruvmanila approved these changes Jul 12, 2024
View reviewed changes
crates/ruff_linter/src/message/text.rs Outdated Show resolved Hide resolved
@charliermarsh @dhruvmanila
Update crates/ruff_linter/src/message/text.rs
85c5270 
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
@charliermarsh charliermarsh enabled auto-merge (squash) July 12, 2024 14:34
zanieb
zanieb approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@charliermarsh charliermarsh merged commit 940df67 into main Jul 12, 2024
16 checks passed
@charliermarsh charliermarsh deleted the charlie/frame branch July 12, 2024 15:21
@adamtheturtle
Copy link

The responsiveness of Astral is incredible. Thanks all!

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@BrewTestBot BrewTestBot mentioned this pull request Jul 15, 2024
Merged
@zanieb zanieb mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
cli Related to the command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

INP001 outputs the code of the file which is part of an implicit namespace package
4 participants
@charliermarsh @adamtheturtle @zanieb @dhruvmanila