Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recommending __slots__ for classes that inherit from more than namedtuple #12531

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Avoid recommending __slots__ for classes that inherit from more than namedtuple #12531

merged 1 commit into from
Jul 26, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Closes #11887.

@charliermarsh charliermarsh added the bug Something isn't working label Jul 26, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) July 26, 2024 14:20
@charliermarsh charliermarsh merged commit 1fe4a5f into main Jul 26, 2024
18 checks passed
@charliermarsh charliermarsh deleted the charlie/slot branch July 26, 2024 14:24
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@BrewTestBot BrewTestBot mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SLOT002 gives a false positive because does take into account multiple inheritance
1 participant
@charliermarsh