[flake8-comprehensions] Set comprehensions not a violation for sum in unnecessary-comprehension-in-call (C419)
#12691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| C419 | 2 | 1 | 1 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+1 -1 violations, +0 -0 fixes in 1 projects; 53 projects unchanged)
apache/airflow (+1 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
- tests/api_connexion/endpoints/test_event_log_endpoint.py:367:24: C419 Unnecessary list comprehension + tests/api_connexion/endpoints/test_event_log_endpoint.py:367:24: C419 Unnecessary set comprehension
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| C419 | 2 | 1 | 1 | 0 | 0 |
| format!("Unnecessary list comprehension") | ||
| match self.comprehension_kind { | ||
| ComprehensionKind::List => format!("Unnecessary list comprehension"), | ||
| ComprehensionKind::Set => format!("Unnecessary set comprehension"), |
There was a problem hiding this comment.
I changed this to a manual match rather than using Display for the (bad) reason that we use the first format! call here to show the example error message in the docs, and "Unnecessary list comprehension" is better than "Unnecessary {} comprehension".
charliermarsh
approved these changes
Aug 6, 2024
dylwil3
added a commit
to dylwil3/ruff
that referenced
this pull request
Aug 7, 2024
…` in `unnecessary-comprehension-in-call` (`C419`) (astral-sh#12691) ## Summary Removes set comprehension as a violation for `sum` when checking `C419`, because set comprehension may de-duplicate entries in a generator, thereby modifying the value of the sum. Closes astral-sh#12690.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes set comprehension as a violation for
sumwhen checkingC419, because set comprehension may de-duplicate entries in a generator, thereby modifying the value of the sum.Closes #12690.