[ruff] Skip tuples with slice expressions in incorrectly-parenthesized-tuple-in-subscript (RUF031)
#12768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably should wait until #12762 is merged in and the subsequent merge conflicts have been resolved. |
|
Thanks @dylwil3! |
|
MichaReiser
approved these changes
Aug 9, 2024
AlexWaygood
reviewed
Aug 9, 2024
crates/ruff_linter/src/rules/ruff/rules/incorrectly_parenthesized_tuple_in_subscript.rs
Outdated
Show resolved
Hide resolved
…zed_tuple_in_subscript.rs
|
The fix being applied in this PR is very specific. But I think that's okay, because I think this syntax error can only occur due to the very specific details of literal slices inside subscripts. So I don't think the bug report reveals a deeper underlying issue that we need to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding parentheses to a tuple in a subscript with elements that include slice expressions causes a syntax error. For example,
d[(1,2,:)]is a syntax error.So, when
lint.ruff.parenthesize-tuple-in-subscript = trueand the tuple includes a slice expression, we skip this check and fix.Closes #12766.