flake8-type-checking: Always recognise relative imports as first-party
#12994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than a u32 `level` argument
|
|
I guess we can't mark it as internal if it fixes a bug. It's important for users to be aware of this when looking at the changelog |
It felt unlikely that it would actually come up in practice, and the ecosystem report strengthened my supposition there, so I wondered if it was really worth putting it in the changelog... but definitely don't feel strongly |
AlexWaygood
added
rule
AlexWaygood
changed the title
is_relative argument to isort::categorize, rather than a u32 level argumentflake8-type-checking: Always recognise relative imports as first-party
MichaReiser
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small refactor. The exact number of dots at the beginning of a relative import isnt relevant to the
isortclassification (and never will be). All that matters is whether there are any dots at the beginning or not. Using a boolean here improves readability and makes it clearer what the argument is for when the function is called from other rules elsewhere in Ruff.In the process, this fixes what I believe is a small bug in the
flake8-type-checkingcode, where we're always passinglevel=0into thecategorize()function. I think this means we may be miscategorising some imports there which would otherwise be categorised as first-party imports due to them being relative imports.