Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anchor tags to README headers #13083

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

calumy
Copy link
Contributor

@calumy calumy commented Aug 23, 2024

Summary

This pull request adds anchor tags to the elements referenced in the table of contents section of the readme used on PyPI as an attempt to fix #7257. This update follows this suggestion to add anchor tags (with no spaces) after the title that is to be linked to.

Test Plan

  • This has been tested on GitHub to check that the additional tags do not interfere with how the read me is rendered; see: https://github.com/calumy/ruff/blob/add-links-to-pypi-docs/README.md
  • MK docs were generated using the generate_mkdocs.py script; however as the added tags are beyond the comment <!-- End section: Overview -->, they are excluded so will not change how the docs are rendered.
  • I was unable to verify how PyPI renders this change, any suggestions would be appreciated and I can follow up on this. Hopefully, the four thumbs up/heart on this comment and this suggestion all suggest that this approach should work.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhruvmanila dhruvmanila changed the title Add anchor tags to readme links Add anchor tags to README headers Aug 26, 2024
@dhruvmanila dhruvmanila added the documentation Improvements or additions to documentation label Aug 26, 2024
@dhruvmanila dhruvmanila merged commit f8f2e2a into astral-sh:main Aug 26, 2024
19 checks passed
@calumy
Copy link
Contributor Author

calumy commented Aug 26, 2024

Thanks!

I think it should work on PyPI as well based on https://github.com/databricks/databricks-sdk-py/blob/main/README.md?plain=1 and https://pypi.org/project/databricks-sdk.

Thanks for finding an example, I couldn't find one at the time of writing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in the PyPi documnetation are broken
2 participants