Make mypy pass on black in knot_benchmark
#13235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes one of the problems highlighted in #13229 in the
knot_benchmark
script. The issue was that recent versions ofaiohttp
led to typing errors in black. These were fixed in psf/black@699b45a, but we pinned a commit of black prior to that inknot_benchmark
; meanwhile, we were installing the latest version ofaiohttp
, because our dependencies for the projects being benchmarked were not pinned.This PR bumps the pinned commit of black to a newer version, and adds a
--exclude-newer
flag (set to today's date) to the installation command so that we won't be impacted by issues like this in the future.Test Plan