Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extensionless Python files for server #13326

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

dhruvmanila
Copy link
Member

Summary

Closes: #12539

Test Plan

Screen.Recording.2024-09-11.at.11.32.32.mov

@dhruvmanila dhruvmanila added the server Related to the LSP server label Sep 11, 2024
@dhruvmanila dhruvmanila changed the title Add support for extensionless Python file for server Add support for extensionless Python files for server Sep 11, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Checking all recognized python files seems like a sensible thing to me. My only concern is that the LSP and CLI now disagree on the file that need checking.

@dhruvmanila
Copy link
Member Author

Checking all recognized python files seems like a sensible thing to me. My only concern is that the LSP and CLI now disagree on the file that need checking.

That's true but this behavior seems reasonable from an editor perspective because the client provides us this information. This is also a regression from ruff-lsp which is resolved with this PR.

@dhruvmanila dhruvmanila merged commit b72d49b into main Sep 11, 2024
20 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/server-language-id branch September 11, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to the LSP server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server doesn't consider a file with no extension
2 participants