Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the revisions of the formatter stability check projects #13380

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Sep 17, 2024

Summary

Bump the revisions of the projects used in the formatter stability check to:

  • Compare against a more recent version of black
  • Increased usage of more recent syntax features.

Some projects have migrated to Ruff. These projects won't give us much signal anymore on how compatible Ruff is with black but are useful when promoting the stable style: many changes mean a lot of churn for projects adopting the new style guide.

Test Plan

Main

project similarity index total files changed files
cpython 0.75869 1812 1669
django 0.99933 2771 181
home-assistant 0.99897 10596 8492
poetry 0.99897 321 14
transformers 0.99726 2660 1119
twine 1.00000 32 7
typeshed 0.99977 3669 75
warehouse 0.99963 653 25
zulip 0.99890 1459 69

PR

project similarity index total files changed files
cpython 0.76424 1959 1781
django 0.99942 2791 76
home-assistant 1.00000 12993 0
poetry 1.00000 444 0
transformers 0.99909 3151 15
twine 1.00000 32 0
typeshed 0.99139 4766 133
warehouse 0.99962 767 33
zulip 1.00000 1699 0
  • warehouse: More changed files
  • typeshed: More changed files
  • twine: fewer changed fiels
  • transfomrers: fewer changed files
  • django: fewer changed files
  • cpython more changed files

I haven't done any comparison what the changes are.

@MichaReiser MichaReiser added the ci Related to internal CI tooling label Sep 17, 2024
@MichaReiser MichaReiser force-pushed the micha/update-formatter-stability-checks branch from c0f27fd to 815fa21 Compare September 17, 2024 11:13
Copy link
Contributor

github-actions bot commented Sep 17, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@MichaReiser MichaReiser force-pushed the micha/update-formatter-stability-checks branch from 815fa21 to 83b40a1 Compare September 17, 2024 12:34
@MichaReiser MichaReiser changed the title Update the revisions of projects still using black in the formatter stability check Update the revisions of the formatter stability check projects Sep 17, 2024
@MichaReiser MichaReiser force-pushed the micha/update-formatter-stability-checks branch from 83b40a1 to 28663f9 Compare September 17, 2024 12:38
@MichaReiser MichaReiser force-pushed the micha/update-formatter-stability-checks branch from 28663f9 to 5a357f4 Compare September 17, 2024 12:42
@MichaReiser MichaReiser requested a review from konstin September 17, 2024 12:51
@MichaReiser MichaReiser merged commit 4eb849a into main Sep 18, 2024
20 checks passed
@MichaReiser MichaReiser deleted the micha/update-formatter-stability-checks branch September 18, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant