-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to macOS14 runner image #13728
Conversation
Thanks for this PR and making us aware of the runner deprecation. We intentionally downgraded the macOS runner in the past because using newer macOS versions resulted in binaries that are incompatible with macOS 11 (#11146, #9834). However, that means that we'll loose macOS 11 support, unless we find another way to cross compile binaries to macOS11. |
I did some research and my general reading is that macOS only supports building for the same or newer versions but there doesn't seem to be a way to build for older macOS versions. That means, this PR drops support for macOS12 unless we find another way of running the release job in a macOs12 image. I found some references of |
Okay, good news. I think I narrowed down why Ruff 0.2 was crashing and we should be fine to just upgrade to the macos 14 runners. I compared the dynamically linked libraries and they're mostly unchanged (ignoring versions)
I also compared the dynamically linked symbols and they are almost identical: https://www.diffchecker.com/x9Nond5g/ That's why I went back to analysing the ruff 0.2 crash stack frame and I stumbled across realm/realm-swift#8369 where one user suggests that this is an XCode bug that was fixed in 15.1
|
I'll upgrade the runner to macOS 14 to get faster compile times. |
I tested that the binary built on macos 14 runs on a mac 10.15. I built the binary using the CI job in #13785 |
I downloaded the macos x86-64 binary and verified that it works on macos 10.15 |
Summary
Updates Github Actions macOS runner images to use macOS 13, since runners using 12 will be unavailable on/around December 3rd of this year.
Closes #13231
For more info, see that issue, as well as actions/runner-images#10721. There will be a 10-hour brownout on each Monday in November.
Test Plan
I did not. 😎 (until after the checks passed)