Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add rule short code to mkdocs tags #14040

Merged
merged 2 commits into from
Nov 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 44 additions & 7 deletions scripts/generate_mkdocs.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,31 +104,68 @@ def clean_file_content(content: str, title: str) -> str:
return f"# {title}\n\n" + content


def add_meta_description(rule_doc: Path) -> str:
"""Add a meta description to the rule doc."""
# Read the rule doc into lines
def generate_rule_metadata(rule_doc: Path) -> None:
"""Add frontmatter metadata containing a rule's code and description.

For example:
```yaml
---
description: Checks for abstract classes without abstract methods.
tags:
- B024
---
```
"""
# Read the rule doc into lines.
with rule_doc.open("r", encoding="utf-8") as f:
lines = f.readlines()

# Get the description from the rule doc lines
# Get the description and rule code from the rule doc lines.
rule_code = None
description = None
what_it_does_found = False
for line in lines:
if line == "\n":
continue

# Assume that the only first-level heading is the rule title and code.
#
# For example: given `# abstract-base-class-without-abstract-method (B024)`,
# extract the rule code (`B024`).
if line.startswith("# "):
rule_code = line.strip().rsplit("(", 1)
rule_code = rule_code[1][:-1]

if line.startswith("## What it does"):
what_it_does_found = True
continue # Skip the '## What it does' line

if what_it_does_found:
if what_it_does_found and not description:
description = line.removesuffix("\n")

if all([rule_code, description]):
break
else:
if not rule_code:
raise ValueError("Missing title line")

if not what_it_does_found:
raise ValueError(f"Missing '## What it does' in {rule_doc}")

with rule_doc.open("w", encoding="utf-8") as f:
f.writelines("\n".join(["---", f"description: {description}", "---", "", ""]))
f.writelines(
"\n".join(
[
"---",
f"description: {description}",
"tags:",
f"- {rule_code}",
"---",
"",
"",
]
)
)
f.writelines(lines)


Expand Down Expand Up @@ -198,7 +235,7 @@ def main() -> None:
# support.
mdformat.file(rule_doc, extensions=["mkdocs", "admon", "no-escape-text"])

add_meta_description(rule_doc)
generate_rule_metadata(rule_doc)

with Path("mkdocs.template.yml").open(encoding="utf8") as fp:
config = yaml.safe_load(fp)
Expand Down
Loading