PyUpgrade: Replace pipes with capture_output=True
#1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet, will review today. |
|
May I suggest to include test cases from pyupgrade? https://github.com/asottile/pyupgrade/blob/main/tests/features/capture_output_test.py Examples I don't see covered: run(["foo"], stdout=None, stderr=PIPE)
from foo import PIPE
from subprocess import run
subprocess.run(["foo"], stdout=PIPE, stderr=PIPE) |
|
(Oh, yes please, I forgot that we were including the pyupgrade test cases.) |
|
I will add them for both of my PRs |
|
🙏 Thank you |
|
She passed em flawlessly! |
renovate bot
referenced
this pull request
in ixm-one/pytest-cmake-presets
Dec 29, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://github.com/charliermarsh/ruff) | `^0.0.198` -> `^0.0.199` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>charliermarsh/ruff</summary> ### [`v0.0.199`](https://github.com/charliermarsh/ruff/releases/tag/v0.0.199) [Compare Source](https://github.com/charliermarsh/ruff/compare/v0.0.198...v0.0.199) #### What's Changed - Check for keyword arguments before the last star argument by [@​andersk](https://github.com/andersk) in [https://github.com/charliermarsh/ruff/pull/1420](https://github.com/charliermarsh/ruff/pull/1420) - Add Support for GitLab CI Code Quality Report Format by [@​saadmk11](https://github.com/saadmk11) in [https://github.com/charliermarsh/ruff/pull/1424](https://github.com/charliermarsh/ruff/pull/1424) - Turn off wasm-pack tests by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1427](https://github.com/charliermarsh/ruff/pull/1427) - Extract duplicated logic into method by [@​hanneskaeufler](https://github.com/hanneskaeufler) in [https://github.com/charliermarsh/ruff/pull/1428](https://github.com/charliermarsh/ruff/pull/1428) - Rewrite xml.etree.cElementTree to xml.etree.ElementTree by [@​colin99d](https://github.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/1426](https://github.com/charliermarsh/ruff/pull/1426) - PyUpgrade: Replace pipes with `capture_output=True` by [@​colin99d](https://github.com/colin99d) in [https://github.com/charliermarsh/ruff/pull/1415](https://github.com/charliermarsh/ruff/pull/1415) - Add a --diff flag to dry-run autofixes by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1431](https://github.com/charliermarsh/ruff/pull/1431) - Split into lint and lint-and-fix methods by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1432](https://github.com/charliermarsh/ruff/pull/1432) - Warn the user when max iteration count is reached by [@​charliermarsh](https://github.com/charliermarsh) in [https://github.com/charliermarsh/ruff/pull/1433](https://github.com/charliermarsh/ruff/pull/1433) #### New Contributors - [@​saadmk11](https://github.com/saadmk11) made their first contribution in [https://github.com/charliermarsh/ruff/pull/1424](https://github.com/charliermarsh/ruff/pull/1424) **Full Changelog**: astral-sh/ruff@v0.0.198...v0.0.199 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43NC4yIiwidXBkYXRlZEluVmVyIjoiMzQuNzQuMiJ9--> Signed-off-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR for visibility. It will remain a draft until the following two issues are resolved:
autofix::Fix::deletionseems to be leaving extra dangling commas and spaces. I am assuming this is my error, and will dig in for a fix.Update: Both of these fixed, lets get this merged.
A part of #827