Make unreachable a test rule for now #15252
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
micha/unreachable-test-rule
branch
from
8bc6dbe to
eb1394b
Compare
|
MichaReiser
force-pushed
the
micha/unreachable-test-rule
branch
from
c3dc9a8 to
476bdd8
Compare
|
CC: @dylwil3 |
AlexWaygood
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I want to do a bugfix release after we reverted the problematic changes with UP006 (see #15250)
but I'm worried that the new unreachable rule results in infinite loops as reported here #15248
That's why I'm excluding the unreachable rule from the bugfix release for now. We should do some more fuzzing before promoting the rule to preview.
Test Plan
cargo testandcargo test --releasethe rule can no longer be selected:
❯ cargo run -- check --select PLW0101 Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.13s Running `target/debug/ruff check --select PLW0101` error: invalid value 'PLW0101' for '--select <RULE_CODE>' For more information, try '--help'.There are no ecosystem changes because the ecosystem tests build with the test rules feature enabled.