Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyflakes] Visit TypeVar's default argument as type expression (F821) #15678

Closed
wants to merge 1 commit into from
Closed

[pyflakes] Visit TypeVar's default argument as type expression (F821) #15678

wants to merge 1 commit into from

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #15677.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood
Copy link
Member

Oh sorry -- I filed #15679 before seeing your comment at #15677 (comment)! I weakly prefer my use of matches!() rather than your use of two equality comparisons (it should be slightly more efficient) -- mind if I have this one? :-)

@InSyncWithFoo
Copy link
Contributor Author

InSyncWithFoo commented Jan 22, 2025 •
edited
Loading

@AlexWaygood Please, go ahead. It was solely my fault for being a tad too slow!

@InSyncWithFoo InSyncWithFoo deleted the F821 branch January 22, 2025 23:00
@AlexWaygood
Copy link
Member

Thanks @InSyncWithFoo!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F821 false positive for TypeVar default parameter unquoted forward reference in type stub (.pyi)
2 participants
@InSyncWithFoo @AlexWaygood