Remove semicolon after TypeScript interface definition #15827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a trailing semicolon after an interface definition in the custom TypeScript section. Currently, this semicolon triggers the error "TS1036: Statements are not allowed in ambient contexts".
leotaku
force-pushed
the
remove-semicolon
branch
from
cdd3561 to
102bc5c
Compare
leotaku
changed the title
ruff_wasm] Remove semicolon after TypeScript interface definition
|
leotaku
added a commit
to leotaku/jupyter-ruff
that referenced
this pull request
Jan 30, 2025
dhruvmanila
approved these changes
Jan 30, 2025
dhruvmanila
added
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes a trailing semicolon after an interface definition in the custom TypeScript section of
ruff_wasm. Currently, this semicolon triggers the error "TS1036: Statements are not allowed in ambient contexts" when including the file and compiling with e.gtsc.Test Plan
I made the change, ran
wasm-packand copied the generated directory manually to mynode_modulesfolder. I then compiled a file importing@astral-sh/ruff-wasm-webagain and confirmed that the compilation error was gone.