Remove assertNotContains

[harupy]

unittest.TestCase doens't have a method named assertNotContains.

[charliermarsh]

Any idea why this was included initially?

[harupy]

It was included in https://github.com/charliermarsh/ruff/pull/1506/files#diff-63acef36182d791074bf61c44d3b9715f8783e11f6314869597ea761cdd48d0aR82. cc @edgarrmondragon

[harupy]

To confirm, the following code prints out False

import unittest

print("assertNotContains" in dir(unittest.TestCase))

[andersk]

Might be a Django thing? https://docs.djangoproject.com/en/4.1/topics/testing/tools/#django.test.SimpleTestCase.assertNotContains

[harupy]

@andersk Thanks for the comment!

[harupy]

If assertNotContains was Django's assertNotContains, would it make sense to emit PT009? I guess not.

[charliermarsh]

Alright I did some digging here. It looks like flake8-pytest-style ported this from flake8-pytest. flake8-pytest originally included Django's SimpleTestCase methods, then removed them here, but left assertNotContains. I'm guessing that was an oversight? So, yes, we should remove it.

[harupy]

@charliermarsh Thanks for the investigation! Agreed.

[charliermarsh]

It's maybe worth auditing the methods here. I think we're missing assertCountEqual? Although maybe that's it.

[harupy]

@charliermarsh Agreed, filed #1736