Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remove-six-compat (UP016) #2332

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Remove remove-six-compat (UP016) #2332

merged 1 commit into from
Jan 30, 2023

Conversation

charliermarsh
Copy link
Member

See discussion in #2049.

@colin99d
Copy link
Contributor

I have this in my PR too.

@charliermarsh
Copy link
Member Author

In which PR?

@charliermarsh charliermarsh merged commit 3ee6a90 into main Jan 30, 2023
@charliermarsh charliermarsh deleted the charlie/up016 branch January 30, 2023 02:20
@charliermarsh
Copy link
Member Author

(Let's rebase it, I'd like this to be a separate PR.)

@spaceone
Copy link
Contributor

:-( it was and will be useful for me in the future (we can drop Py2 next year)

@charliermarsh
Copy link
Member Author

@spaceone - Sorry about that :( I recommend using pyupgrade for this check. I felt like the implementation in Ruff was complex and under-tested since it's a rarely-run rule.

@eli-schwartz eli-schwartz mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charliermarsh @colin99d @spaceone