Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing_macros: Add missing full feature to syn dependency #4722

Merged
merged 1 commit into from
May 30, 2023

Conversation

MichaReiser
Copy link
Member

Summary

Fix the standalone build of ruff_testing_macros.

Before:

error[E0432]: unresolved imports `syn::FnArg`, `syn::ItemFn`, `syn::Pat`
  --> crates/ruff_testing_macros/src/lib.rs:13:61
   |
13 | use syn::{bracketed, parse_macro_input, parse_quote, Error, FnArg, ItemFn, LitStr, Pat, Token};
   |                                                             ^^^^^  ^^^^^^          ^^^
   |                                                             |      |               |
   |                                                             |      |               no `Pat` in the root
   |                                                             |      |               help: a similar name exists in the module: `Path`
   |                                                             |      no `ItemFn` in the root
   |                                                             no `FnArg` in the root

For more information about this error, try `rustc --explain E0432`.
error: could not compile `ruff_testing_macros` due to previous error

Test Plan

❯ cargo build -p ruff_testing_macros
   Compiling proc-macro2 v1.0.56
   Compiling unicode-ident v1.0.8
   Compiling quote v1.0.27
   Compiling glob v0.3.1
   Compiling syn v2.0.15
   Compiling ruff_testing_macros v0.0.0 (/home/micha/astral/ruff/crates/ruff_testing_macros)
    Finished dev [unoptimized + debuginfo] target(s) in 2.54s

@MichaReiser
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@MichaReiser MichaReiser enabled auto-merge (squash) May 30, 2023 07:30
@MichaReiser MichaReiser merged commit 236074f into main May 30, 2023
@MichaReiser MichaReiser deleted the fix-testing-macros-build branch May 30, 2023 07:42
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     17.5±0.40ms     2.3 MB/sec    1.00     17.6±0.34ms     2.3 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.13ms     4.0 MB/sec    1.01      4.2±0.23ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    530.8±9.57µs     5.6 MB/sec    1.01   534.8±20.80µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.2±0.18ms     3.6 MB/sec    1.03      7.4±0.23ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.01      8.2±0.14ms     4.9 MB/sec    1.00      8.1±0.15ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1777.4±40.65µs     9.4 MB/sec    1.01  1800.6±33.99µs     9.2 MB/sec
linter/default-rules/numpy/globals.py      1.00    216.5±9.26µs    13.6 MB/sec    1.02    220.1±6.83µs    13.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.07ms     6.8 MB/sec    1.02      3.8±0.08ms     6.7 MB/sec
parser/large/dataset.py                    1.00      6.4±0.08ms     6.3 MB/sec    1.00      6.4±0.12ms     6.3 MB/sec
parser/numpy/ctypeslib.py                  1.00  1281.7±25.83µs    13.0 MB/sec    1.00  1279.5±41.25µs    13.0 MB/sec
parser/numpy/globals.py                    1.00    127.7±2.67µs    23.1 MB/sec    1.01    129.3±5.70µs    22.8 MB/sec
parser/pydantic/types.py                   1.01      2.8±0.06ms     9.1 MB/sec    1.00      2.8±0.07ms     9.1 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.08     21.7±0.77ms  1922.1 KB/sec    1.00     20.1±1.12ms     2.0 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.03      5.3±0.21ms     3.1 MB/sec    1.00      5.2±0.21ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.05   632.9±23.43µs     4.7 MB/sec    1.00   605.0±39.02µs     4.9 MB/sec
linter/all-rules/pydantic/types.py         1.08      8.9±0.38ms     2.8 MB/sec    1.00      8.3±0.36ms     3.1 MB/sec
linter/default-rules/large/dataset.py      1.10     10.4±0.37ms     3.9 MB/sec    1.00      9.5±0.39ms     4.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.14      2.3±0.20ms     7.1 MB/sec    1.00      2.1±0.09ms     8.1 MB/sec
linter/default-rules/numpy/globals.py      1.00   257.7±14.08µs    11.5 MB/sec    1.00   258.3±17.02µs    11.4 MB/sec
linter/default-rules/pydantic/types.py     1.04      4.6±0.21ms     5.6 MB/sec    1.00      4.4±0.20ms     5.8 MB/sec
parser/large/dataset.py                    1.00      8.1±0.27ms     5.0 MB/sec    1.03      8.3±0.21ms     4.9 MB/sec
parser/numpy/ctypeslib.py                  1.00  1553.8±46.19µs    10.7 MB/sec    1.00  1547.5±60.79µs    10.8 MB/sec
parser/numpy/globals.py                    1.00    154.7±7.35µs    19.1 MB/sec    1.04    161.6±7.98µs    18.3 MB/sec
parser/pydantic/types.py                   1.00      3.4±0.09ms     7.4 MB/sec    1.03      3.5±0.11ms     7.2 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant