Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to the nursery; tweak icons #5637

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Summary

We now always render the icons, but very faintly if inactive, and always right-align. This ensures consistent alignment as you scroll down the page:

Screen Shot 2023-07-09 at 10 45 50 PM

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jul 10, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) July 10, 2023 02:46
@charliermarsh charliermarsh merged commit c9d7c0d into main Jul 10, 2023
15 checks passed
@charliermarsh charliermarsh deleted the charlie/nursery-docs branch July 10, 2023 03:09
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.13      9.4±0.02ms     4.3 MB/sec    1.00      8.3±0.01ms     4.9 MB/sec
formatter/numpy/ctypeslib.py               1.10   1948.6±2.54µs     8.5 MB/sec    1.00   1769.7±3.52µs     9.4 MB/sec
formatter/numpy/globals.py                 1.06    207.3±0.39µs    14.2 MB/sec    1.00    194.9±0.21µs    15.1 MB/sec
formatter/pydantic/types.py                1.12      4.4±0.01ms     5.7 MB/sec    1.00      4.0±0.02ms     6.4 MB/sec
linter/all-rules/large/dataset.py          1.00     13.8±0.03ms     2.9 MB/sec    1.01     13.9±0.03ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.01ms     4.8 MB/sec    1.00      3.5±0.01ms     4.7 MB/sec
linter/all-rules/numpy/globals.py          1.00    361.0±1.31µs     8.2 MB/sec    1.00    362.2±1.55µs     8.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.1±0.01ms     4.2 MB/sec    1.01      6.2±0.01ms     4.1 MB/sec
linter/default-rules/large/dataset.py      1.00      7.1±0.01ms     5.8 MB/sec    1.01      7.2±0.01ms     5.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1458.8±3.98µs    11.4 MB/sec    1.01   1468.4±2.87µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    155.5±0.30µs    19.0 MB/sec    1.01    156.5±0.28µs    18.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.2±0.01ms     8.1 MB/sec    1.01      3.2±0.01ms     8.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     12.5±0.49ms     3.2 MB/sec    1.02     12.8±0.55ms     3.2 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.6±0.11ms     6.3 MB/sec    1.03      2.7±0.12ms     6.1 MB/sec
formatter/numpy/globals.py                 1.00   303.0±17.75µs     9.7 MB/sec    1.04   315.2±29.03µs     9.4 MB/sec
formatter/pydantic/types.py                1.00      5.9±0.19ms     4.3 MB/sec    1.02      6.0±0.21ms     4.3 MB/sec
linter/all-rules/large/dataset.py          1.00     20.3±0.61ms     2.0 MB/sec    1.04     21.2±0.86ms  1965.0 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.4±0.21ms     3.1 MB/sec    1.01      5.4±0.21ms     3.1 MB/sec
linter/all-rules/numpy/globals.py          1.00   641.8±27.22µs     4.6 MB/sec    1.03   662.7±24.90µs     4.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      9.2±0.37ms     2.8 MB/sec    1.03      9.4±0.36ms     2.7 MB/sec
linter/default-rules/large/dataset.py      1.00     10.5±0.32ms     3.9 MB/sec    1.03     10.8±0.37ms     3.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.2±0.10ms     7.5 MB/sec    1.01      2.2±0.09ms     7.4 MB/sec
linter/default-rules/numpy/globals.py      1.00   266.2±19.10µs    11.1 MB/sec    1.03   275.0±11.38µs    10.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.7±0.19ms     5.5 MB/sec    1.04      4.9±0.16ms     5.3 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant