-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a match statement for builtin detection #5798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/builtin
branch
from
July 16, 2023 04:43
03a5f36
to
7e331bd
Compare
charliermarsh
force-pushed
the
charlie/builtin
branch
from
July 16, 2023 04:52
7e331bd
to
5477b4e
Compare
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+1, -1, 0 error(s)) bokeh (+1, -1)
- src/bokeh/models/callbacks.py:25:1: A001 Variable `any` is shadowing a Python builtin + src/bokeh/models/callbacks.py:25:42: A001 Variable `any` is shadowing a Python builtin
BenchmarkLinux
Windows
|
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 19, 2023
## Summary We've seen speed-ups in the past by converting from slice iteration to match statements; this just does the same for built-in checks.
konstin
pushed a commit
that referenced
this pull request
Jul 19, 2023
## Summary We've seen speed-ups in the past by converting from slice iteration to match statements; this just does the same for built-in checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've seen speed-ups in the past by converting from slice iteration to match statements; this just does the same for built-in checks.