Use cursor based lexer #6012
Merged
Use cursor based lexer #6012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
use-cursor-based-lexer
branch
3 times, most recently
from
1aaef3e to
a8c1609
Compare
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+12, -12, 0 error(s)) airflow (+12, -12)
- tests/api_connexion/endpoints/test_dag_endpoint.py:124:25: S108 Probable insecure usage of temporary file or directory: "/tmp/dag_" + tests/api_connexion/endpoints/test_dag_endpoint.py:124:27: S108 Probable insecure usage of temporary file or directory: "/tmp/dag_" - tests/api_connexion/endpoints/test_import_error_endpoint.py:239:49: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" + tests/api_connexion/endpoints/test_import_error_endpoint.py:239:51: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" - tests/api_connexion/endpoints/test_import_error_endpoint.py:241:48: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" + tests/api_connexion/endpoints/test_import_error_endpoint.py:241:50: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" - tests/api_connexion/endpoints/test_import_error_endpoint.py:242:48: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" + tests/api_connexion/endpoints/test_import_error_endpoint.py:242:50: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" - tests/api_connexion/endpoints/test_import_error_endpoint.py:244:56: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" + tests/api_connexion/endpoints/test_import_error_endpoint.py:244:58: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" - tests/api_connexion/endpoints/test_import_error_endpoint.py:251:26: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" + tests/api_connexion/endpoints/test_import_error_endpoint.py:251:28: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" - tests/api_connexion/endpoints/test_import_error_endpoint.py:269:26: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" + tests/api_connexion/endpoints/test_import_error_endpoint.py:269:28: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" - tests/api_connexion/endpoints/test_import_error_endpoint.py:285:26: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" + tests/api_connexion/endpoints/test_import_error_endpoint.py:285:28: S108 Probable insecure usage of temporary file or directory: "/tmp/file_" - tests/system/providers/google/cloud/dataproc/example_dataproc_pyspark.py:64:23: S108 Probable insecure usage of temporary file or directory: "/tmp/" + tests/system/providers/google/cloud/dataproc/example_dataproc_pyspark.py:64:25: S108 Probable insecure usage of temporary file or directory: "/tmp/" - tests/system/providers/google/cloud/dataproc/example_dataproc_sparkr.py:63:23: S108 Probable insecure usage of temporary file or directory: "/tmp/" + tests/system/providers/google/cloud/dataproc/example_dataproc_sparkr.py:63:25: S108 Probable insecure usage of temporary file or directory: "/tmp/" - tests/system/providers/google/cloud/ml_engine/example_mlengine.py:61:15: S108 Probable insecure usage of temporary file or directory: "/tmp/" + tests/system/providers/google/cloud/ml_engine/example_mlengine.py:61:30: S108 Probable insecure usage of temporary file or directory: "/tmp/" - tests/system/providers/google/cloud/ml_engine/example_mlengine_async.py:61:15: S108 Probable insecure usage of temporary file or directory: "/tmp/" + tests/system/providers/google/cloud/ml_engine/example_mlengine_async.py:61:30: S108 Probable insecure usage of temporary file or directory: "/tmp/"
BenchmarkLinuxWindows |
MichaReiser
force-pushed
the
use-cursor-based-lexer
branch
4 times, most recently
from
e1cddf1 to
a46b9c0
Compare
MichaReiser
force-pushed
the
use-cursor-based-lexer
branch
4 times, most recently
from
defc8d0 to
78b0ee8
Compare
MichaReiser
commented
Jul 26, 2023
| @@ -1 +1 @@ | |||
| broken "§=($/=(") | |||
| broken "§=($/=() | |||
There was a problem hiding this comment.
I had to create another lexer error because the lexer no longer marks in-balanced parentheses pairs as errors (because it also doesn't complain about [{(]}) as unbalanced even though the parens are closed in the wrong order.
|
The ecosystem changes are due to the now more accurate ranges of f-string parts. |
MichaReiser
force-pushed
the
use-cursor-based-lexer
branch
from
78b0ee8 to
e07af0e
Compare
|
The benchmarks look great! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pulls in the cursor-based Lexer implementation that significantly speeds up performance. The RustPython-parser PR contains a more in-depth description of the change.
Test Plan
cargo test, ecosystem check