[pylint] Add fix for subprocess-run-without-check (PLW1510)

crates/ruff/resources/test/fixtures/pylint/subprocess_run_without_check.py

@@ -3,6 +3,10 @@
 # Errors.
 subprocess.run("ls")
 subprocess.run("ls", shell=True)
+subprocess.run(
+    ["ls"],
+    shell=False,
+)
 
 # Non-errors.
 subprocess.run("ls", check=True)

crates/ruff/src/rules/pylint/rules/subprocess_run_without_check.rs

@@ -1,4 +1,6 @@
-use ruff_diagnostics::{Diagnostic, Violation};
+use ruff_text_size::TextSize;
+
+use ruff_diagnostics::{AlwaysAutofixableViolation, Diagnostic, Edit, Fix};
 use ruff_macros::{derive_message_formats, violation};
 use ruff_python_ast as ast;
 use ruff_python_ast::Ranged;
@@ -41,11 +43,15 @@ use crate::checkers::ast::Checker;
 #[violation]
 pub struct SubprocessRunWithoutCheck;
 
-impl Violation for SubprocessRunWithoutCheck {
+impl AlwaysAutofixableViolation for SubprocessRunWithoutCheck {
     #[derive_message_formats]
     fn message(&self) -> String {
         format!("`subprocess.run` without explicit `check` argument")
     }
+
+    fn autofix_title(&self) -> String {
+        "Add an explicit check=False".to_string()
+    }
 }
 
 /// PLW1510
@@ -56,10 +62,21 @@ pub(crate) fn subprocess_run_without_check(checker: &mut Checker, call: &ast::Ex
         .is_some_and(|call_path| matches!(call_path.as_slice(), ["subprocess", "run"]))
     {
         if call.arguments.find_keyword("check").is_none() {
-            checker.diagnostics.push(Diagnostic::new(
-                SubprocessRunWithoutCheck,
-                call.func.range(),
-            ));
+            let mut diagnostic = Diagnostic::new(SubprocessRunWithoutCheck, call.func.range());
+            let text: &str = checker.locator().slice(call.range());
+            let ends_with_comma = text[..text.len() - 1].trim_end().ends_with(',');
+            diagnostic.set_fix(Fix::automatic(Edit::insertion(
+                {
+                    if ends_with_comma {
+                        "check=False"
+                    } else {
+                        ", check=False"
+                    }
+                }
+                .to_string(),
+                call.range().end() - TextSize::from(1),
+            )));
+            checker.diagnostics.push(diagnostic);
         }
     }
 }

crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLW1510_subprocess_run_without_check.py.snap

@@ -1,22 +1,66 @@
 ---
 source: crates/ruff/src/rules/pylint/mod.rs
 ---
-subprocess_run_without_check.py:4:1: PLW1510 `subprocess.run` without explicit `check` argument
+subprocess_run_without_check.py:4:1: PLW1510 [*] `subprocess.run` without explicit `check` argument
   |
 3 | # Errors.
 4 | subprocess.run("ls")
   | ^^^^^^^^^^^^^^ PLW1510
 5 | subprocess.run("ls", shell=True)
+6 | subprocess.run(
   |
+  = help: Add an explicit check=False
 
-subprocess_run_without_check.py:5:1: PLW1510 `subprocess.run` without explicit `check` argument
+ℹ Fix
+1 1 | import subprocess
+2 2 | 
+3 3 | # Errors.
+4   |-subprocess.run("ls")
+  4 |+subprocess.run("ls", check=False)
+5 5 | subprocess.run("ls", shell=True)
+6 6 | subprocess.run(
+7 7 |     ["ls"],
+
+subprocess_run_without_check.py:5:1: PLW1510 [*] `subprocess.run` without explicit `check` argument
   |
 3 | # Errors.
 4 | subprocess.run("ls")
 5 | subprocess.run("ls", shell=True)
   | ^^^^^^^^^^^^^^ PLW1510
-6 | 
-7 | # Non-errors.
+6 | subprocess.run(
+7 |     ["ls"],
   |
+  = help: Add an explicit check=False
+
+ℹ Fix
+2 2 | 
+3 3 | # Errors.
+4 4 | subprocess.run("ls")
+5   |-subprocess.run("ls", shell=True)
+  5 |+subprocess.run("ls", shell=True, check=False)
+6 6 | subprocess.run(
+7 7 |     ["ls"],
+8 8 |     shell=False,
+
+subprocess_run_without_check.py:6:1: PLW1510 [*] `subprocess.run` without explicit `check` argument
+  |
+4 | subprocess.run("ls")
+5 | subprocess.run("ls", shell=True)
+6 | subprocess.run(
+  | ^^^^^^^^^^^^^^ PLW1510
+7 |     ["ls"],
+8 |     shell=False,
+  |
+  = help: Add an explicit check=False
+
+ℹ Fix
+6  6  | subprocess.run(
+7  7  |     ["ls"],
+8  8  |     shell=False,
+9     |-)
+   9  |+check=False)
+10 10 | 
+11 11 | # Non-errors.
+12 12 | subprocess.run("ls", check=True)