Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use is_magic where possible #6945

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Re-use is_magic where possible #6945

merged 1 commit into from
Aug 28, 2023

Conversation

jelly
Copy link
Contributor

@jelly jelly commented Aug 28, 2023

Summary

Use is_magic where possible

Test Plan

Unit tests

charliermarsh
charliermarsh approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the internal An internal refactor or improvement label Aug 28, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) August 28, 2023 15:21
@charliermarsh charliermarsh merged commit af61abc into astral-sh:main Aug 28, 2023
16 checks passed
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@jelly jelly deleted the use-is_magic branch August 28, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jelly @charliermarsh