Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend reimplemented-starmap (FURB140) to catch calls with a single and starred argument #7768

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

tjkuson
Copy link
Contributor

@tjkuson tjkuson commented Oct 2, 2023

Summary

Closes #7636.

Test Plan

cargo test

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 2, 2023

CodSpeed Performance Report

Merging #7768 will degrade performances by 2.37%

Comparing tjkuson:star-starmap (b890639) with main (f872c3b)

Summary

❌ 1 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main tjkuson:star-starmap Change
linter/default-rules[pydantic/types.py] 38 ms 38.9 ms -2.37%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@tjkuson tjkuson marked this pull request as ready for review October 2, 2023 22:21
@charliermarsh charliermarsh added the rule Implementing or modifying a lint rule label Oct 3, 2023
@charliermarsh charliermarsh merged commit e129f77 into astral-sh:main Oct 3, 2023
15 of 16 checks passed
@tjkuson tjkuson deleted the star-starmap branch October 3, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement on reimplemented-starmap rule (FURB140)
2 participants