Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect msgspec.Struct default-copy semantics #7786

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Respect msgspec.Struct default-copy semantics #7786

merged 1 commit into from
Oct 3, 2023

Conversation

charliermarsh
Copy link
Member

Summary

The carve-out we have in RUF012 for Pydantic classes also applies to msgspec.Struct.

Closes #7785.

@charliermarsh charliermarsh changed the title Respect msgspec.Struct's default-copy semantics Respect msgspec.Struct default-copy semantics Oct 3, 2023
@charliermarsh charliermarsh added the bug Something isn't working label Oct 3, 2023
@jcrist
Copy link

jcrist commented Oct 3, 2023

Thanks for the fix!

@charliermarsh charliermarsh enabled auto-merge (squash) October 3, 2023 16:42
@charliermarsh charliermarsh merged commit 90c259b into main Oct 3, 2023
14 checks passed
@charliermarsh charliermarsh deleted the charlie/msgspec branch October 3, 2023 16:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@p-linnane p-linnane mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False RUF012 on empty mutable collections as default values in msgspec.Structs
2 participants
@charliermarsh @jcrist