-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show changed files when running under --check
#7788
Conversation
0d29d2d
to
87f6383
Compare
What's this look like for multiple files? |
It shows one line (like the above) per file:
(The filenames are bolded.) |
And we don't mention the files that are correctly formatted? Seems reasonable to me. Should we say "Would reformat: foo.py" instead? |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
87f6383
to
860f7c1
Compare
Changed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; why the refactor?
Which part? Overall, I needed to store the results with paths so that we could report on individual paths. The |
Summary
We now list each changed file when running with
--check
.Closes #7782.
Test Plan