Write summary messages to stderr when fixing via stdin (instead of omitting them) #7838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Oct 6, 2023
| @@ -208,6 +208,7 @@ pub fn check(args: CheckCommand, log_level: LogLevel) -> Result<ExitStatus> { | |||
| } | |||
| _ => Box::new(BufWriter::new(io::stdout())), | |||
| }; | |||
| let stderr_writer = Box::new(BufWriter::new(io::stderr())); | |||
There was a problem hiding this comment.
Should I move this down? Maybe. Should we write other things to stderr? Maybe.
|
Useful for testing in #7790 and arguably a better UX. |
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
charliermarsh
approved these changes
Oct 6, 2023
zanieb
added a commit
that referenced
this pull request
Oct 6, 2023
konstin
pushed a commit
that referenced
this pull request
Oct 11, 2023
…itting them) (#7838) Previously we just omitted diagnostic summaries when using `--fix` or `--diff` with a stdin file. Now, we still write the summaries to stderr instead of the main writer (which is generally stdout but could be changed by `--output-file`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we just omitted diagnostic summaries when using
--fixor--diffwith a stdin file. Now, we still write the summaries to stderr instead of the main writer (which is generally stdout but could be changed by--output-file).