Fix diff (old and new were reversed) #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
konstin
pushed a commit
that referenced
this pull request
Oct 11, 2023
## Summary Fixes #7853. The old and new source files were reversed in the call to `TextDiff::from_lines`, so the diff output of the CLI was also reversed. ## Test Plan Two snapshots were updated in the process, so any reversal should be caught :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7853.
The old and new source files were reversed in the call to
TextDiff::from_lines, so the diff output of the CLI was also reversed.Test Plan
Two snapshots were updated in the process, so any reversal should be caught :)