Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less scary ruff format message #7867

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 9, 2023

The ruff formatter has stabilized a good bit since when we added the original message "intended only for experimentation" message. It's time for a less scary message to indicate it is much closer to stable usage than it used to be.

I'm not particular about the specific wording, feel free to change the text to something better.

image

The ruff formatter has stabilized a good bit since when we added the original message "intended only for experimentation" message. It's time for a less scary message to indicate it is much closer to stable usage than it used to be.

I'm not particular about the specific wording, feel free to change the text to something better.

![image](https://github.com/astral-sh/ruff/assets/6826232/225db573-bfda-446f-a403-a577ee270a0b)
@konstin konstin added the formatter Related to the formatter label Oct 9, 2023
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest:

warn_user_once!("`ruff format` is not yet stable, and subject to change in future versions.");

@charliermarsh charliermarsh enabled auto-merge (squash) October 11, 2023 01:02
@charliermarsh charliermarsh merged commit ec9d5cd into main Oct 11, 2023
15 checks passed
@charliermarsh charliermarsh deleted the stablize-ruff-format-a-little branch October 11, 2023 11:46
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants