Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix edge case with PIE804 #7922

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix edge case with PIE804 #7922

merged 1 commit into from
Oct 11, 2023

Conversation

diceroll123
Copy link
Contributor

@diceroll123 diceroll123 commented Oct 11, 2023 •
edited
Loading

Summary

foo(**{}) was an overlooked edge case for PIE804 which introduced a crash within the Fix, introduced in #7884.

I've made it so that foo(**{}) turns into foo() when applied with --fix, but is that desired/expected? 🤔 Should we just ignore instead?

Test Plan

cargo test

@charliermarsh
Copy link
Member

Thanks!

@charliermarsh charliermarsh merged commit a71c4df into astral-sh:main Oct 11, 2023
16 checks passed
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@p-linnane p-linnane mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diceroll123 @charliermarsh