Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept --target-version in the format CLI #8055

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Summary

This doesn't affect behavior yet (see: #7234), but it will be needed in the future, and it's surprising to users that it doesn't exist.

Closes #8051.

@charliermarsh charliermarsh added cli Related to the command-line interface formatter Related to the formatter labels Oct 18, 2023
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

@MichaReiser
Copy link
Member

I'm conflicted on this. I find it weird to have no-op flags.

@charliermarsh
Copy link
Member Author

I think we should include it. It’s sort of “incidentally” a no-op. It does set the target version, we’re just not using it in any formatting decisions yet. But we will soon (for preview style, at least).

@MichaReiser
Copy link
Member

Yeah. But it's a no-op feature that you can't test.

@charliermarsh charliermarsh merged commit 2e225d7 into main Oct 19, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/target-version branch October 19, 2023 00:14
@charliermarsh
Copy link
Member Author

So it must be working...

@henryiii
Copy link
Contributor

Does this also get picked up from the standard python-requires, like the target-version for linting (and black does this too)?

@charliermarsh
Copy link
Member Author

Yup, should be, but I will confirm.

kdeldycke added a commit to kdeldycke/workflows that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[formatter] target-python option
3 participants