Rename tab-size to indent-width
#8082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2023
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
charliermarsh
approved these changes
Oct 20, 2023
crates/ruff_workspace/src/options.rs
Outdated
| /// This option changes the number of spaces the formatter inserts when | ||
| /// using soft-tabs (`indent-style = space`). | ||
| /// | ||
| /// PEP8 recommends using 4 spaces per [indentation level](https://peps.python.org/pep-0008/#indentation). |
There was a problem hiding this comment.
Nit: We typically stylize as PEP 8.
There was a problem hiding this comment.
I also fixed the reference to PEP257
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
dhruvmanila
approved these changes
Oct 20, 2023
MichaReiser
force-pushed
the
rename-length-options
branch
from
596a8ad
to
bcfb73b
Compare
MichaReiser
force-pushed
the
rename-tab-size-to-tab-width
branch
from
e7d0144
to
213ea75
Compare
MichaReiser
changed the base branch from
rename-length-options
to
add-formatter-to-line-length-doc
MichaReiser
force-pushed
the
rename-tab-size-to-tab-width
branch
from
213ea75
to
c567862
Compare
MichaReiser
force-pushed
the
rename-tab-size-to-tab-width
branch
from
c567862
to
53fcb16
Compare
MichaReiser
commented
Oct 24, 2023
| @@ -305,7 +305,7 @@ pub(crate) fn fits_or_shrinks( | |||
| node: AnyNodeRef, | |||
| locator: &Locator, | |||
| line_length: LineLength, | |||
| tab_size: TabSize, | |||
| tab_size: IndentWidth, | |||
There was a problem hiding this comment.
We could rename all these fields but here the indent-width is used as tab-width only, so keeping it as is felt correct.
MichaReiser
force-pushed
the
add-formatter-to-line-length-doc
branch
from
1c1aed4
to
de85ade
Compare
MichaReiser
force-pushed
the
rename-tab-size-to-tab-width
branch
from
53fcb16
to
0df0d26
Compare
MichaReiser
force-pushed
the
rename-tab-size-to-tab-width
branch
from
0df0d26
to
a205ebf
Compare
MichaReiser
force-pushed
the
rename-tab-size-to-tab-width
branch
from
a205ebf
to
b2649f2
Compare
|
@charliermarsh feel free to hit merge when the changes look reasonable to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the
tab-sizeconfiguration option toindent-widthto express that the formatter uses the option to determine the indentation width AND as tab width.I first preferred naming the option
tab-widthbut then decided to go withindent-widthbecause:indent-styleoptionindent-widthspaces.Closes #7643
Test Plan
Added integration test