Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix name of magic-trailing-comma option in README #8200

Merged
merged 2 commits into from
Oct 25, 2023
Merged

docs: fix name of magic-trailing-comma option in README #8200

merged 2 commits into from
Oct 25, 2023

Conversation

ran-isenberg
Copy link
Contributor

Fix issue #8199 #8199

Summary

Remove 'magic-trailing-comma' setting from readme file. It raises an error. see #8199

Test Plan

Removed 'magic-trailing-comma' and was able to run ruff format.

MichaReiser
MichaReiser approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed the example to instead use the correct option name

@MichaReiser MichaReiser changed the title docs: remove incorrect setting from readme docs: fix name of magic-trailing-comma option in README Oct 25, 2023
@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Oct 25, 2023
@MichaReiser MichaReiser enabled auto-merge (squash) October 25, 2023 06:21
@MichaReiser MichaReiser merged commit 1ee73bd into astral-sh:main Oct 25, 2023
@ran-isenberg ran-isenberg deleted the patch-1 branch October 25, 2023 06:32
@p-linnane p-linnane mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ran-isenberg @MichaReiser