Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve trailing semicolons when using fmt: off #8275

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Oct 27, 2023

Summary

Preserve the semicolons terminating statements when using fmt: off

Test Plan

Added test. Verified that the similarity index is unchanged.

@MichaReiser
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

ℹ️ ecosystem check detected format changes. (+12 -9 lines in 7 files in 41 projects)

rotki/rotki (+12 -9 lines across 7 files)

ruff format

rotkehlchen/chain/ethereum/defi/protocols.py~L2

 
 This module handles the defi protocol list, stored in DEFI_PROTOCOLS.
 """
+
 from typing import NamedTuple
 
 

rotkehlchen/chain/ethereum/interfaces/ammswap/ammswap.py~L7

 - Uniswap Module
 - Sushiswap Module
 """
+
 import logging
 from collections import defaultdict
 from typing import TYPE_CHECKING, Optional, Union

rotkehlchen/globaldb/cache.py~L1

 """Functions dealing with the general_cache table of the Global DB"""
+
 from collections.abc import Iterable
 from typing import Optional, Union
 

rotkehlchen/tests/exchanges/test_coinbasepro.py~L7

 TODO: Make some mock tests at some point
 """
 
-
 import warnings as test_warnings
 from enum import Enum
 from typing import Literal

tools/assets_database/main.py~L1

 """Tool to pull an assets database from Github, and apply updates to it"""
+
 from gevent import monkey
 
 monkey.patch_all()  # isort:skip

tools/pyinstaller_hooks/pre_find_module_path/hook-distutils.py~L23

 the latter is intended for use _only_ from within venvs.
 """
 
-
 import distutils
 import os
 

tools/scripts/pylint_useless_suppression.py~L12

 
 We should probably open bug reports to pylint for all of these at some point.
 """
+
 import io
 import re
 import subprocess

Base automatically changed from fmt-skip-preserve-semicolon to main October 30, 2023 00:07
@MichaReiser MichaReiser merged commit 3ccca33 into main Oct 30, 2023
17 checks passed
@MichaReiser MichaReiser deleted the fmt-off-preserve-semicolon branch October 30, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatter Related to the formatter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants