Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff ecosystem: pass no-preview cli arg by default #8775

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Ruff ecosystem: pass no-preview cli arg by default #8775

merged 7 commits into from
Nov 20, 2023

Conversation

T-256
Copy link
Contributor

@T-256 T-256 commented Nov 20, 2023

Addresses #8489 (comment)
That issues still exist on formatter, but since black doesn't support no-preview cli arg, I didn't include it in this PR.

@zanieb
Copy link
Member

zanieb commented Nov 20, 2023

Thanks! You can add this to the formatter too. We don't use comparisons with Black in CI anyway.

@zanieb zanieb added the ci Related to internal CI tooling label Nov 20, 2023
@T-256 T-256 changed the title lint ecosystem: respect no-preview Ruff ecosystem: pass no-preview cli arg by default Nov 20, 2023
zanieb
zanieb approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zanieb
Add python module to changes
445d809 
We should test the ecosystem on ecosystem module changes for example
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@zanieb zanieb merged commit aec80dc into astral-sh:main Nov 20, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

Assignees
No one assigned
Labels
ci Related to internal CI tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T-256 @zanieb